Skip to content

Add wallet classes#89

Open
astrojarred wants to merge 146 commits intoPython-Cardano:mainfrom
astrojarred:add-wallet-classes
Open

Add wallet classes#89
astrojarred wants to merge 146 commits intoPython-Cardano:mainfrom
astrojarred:add-wallet-classes

Conversation

@astrojarred
Copy link
Contributor

@astrojarred astrojarred commented Sep 28, 2022 •
edited
Loading

This is still a WIP but I wanted to get the ball rolling on this! Lots of basic functionality is now here, along with the first few tests and examples. See /examples/wallet.py for some examples of the most basic functionality.

Current capabilities:

  • Generate keys
  • Load keys
  • Query utxos
  • Send ada
  • Send specific UTxOs
  • Get senders of all UTxOs
  • Get metadata for all held tokens
  • Get utxo block times and sort utxos
  • Mint / Burn tokens
  • Automatically load in token polices where wallet is a signer
  • Automatically create BlockFrost Chain Context (mainnet, preprod, and preview)
  • Attach messages to transactions
  • Sign messages
  • Add custom metadata fields
  • Multi-output transactions
  • Register wallet
  • Stake wallet
  • Withdraw rewards
  • Generate fully manual transactions that can do any / all of the above
  • Integrate strict type checking
  • Write tests
  • Add more examples

Future additions (possibly later PRs):

  • Draft and sign multi-sig transactions
  • Interaction with native scripts
  • Interaction with plutus scripts
  • Load wallets with mnemonic phrase (integrating HDWallet)

Now currently figuring out how to write tests for the transaction methods, using test_transaction.py for inspiration.

astrojarred added 30 commits June 29, 2022 23:49
@astrojarred
Add beginnings of easy class
f690c16
@astrojarred
Rename base Amount class
c76a8ff
@astrojarred
Update Imports
58647e7
@astrojarred
Check Token metadata for issues
f27b750
@astrojarred
Automatically add blockfrost context if correct env vars are set
c6646de
@astrojarred
Add methods for sending transactions
2c5c5d6
@astrojarred
Start adding a mint token class
ae84ee0
@astrojarred
Add TokenPolicy class
21ee7a8
@astrojarred
Add bytes_name() to Token
0e27088
@astrojarred
Add message option to transactions
a025a95
@astrojarred
Add working token minter
8aa8d71
@astrojarred
Add id property to token policy
14ad5f0
@astrojarred
Remove policy datafield from Wallet
85e3838
@astrojarred
Add method to fetch conchain metadata for Tokens
17c1ce9
@astrojarred
Remove unneeded import
c87d906
@astrojarred
Add method to get all wallet token metadata
72c98ad
@astrojarred
Automatically load in all wallet policies for which it is a signer
a3164de
@astrojarred
Get Wallet utxos block times and sort
d6e2489
@astrojarred
Add burning capabilities to mint_tokens
ed5d42b
@astrojarred
Merge branch 'cffls:main' into add-ease-classes
9f2238e
@astrojarred
Merge branch 'cffls:main' into add-ease-classes
eb89412
@astrojarred
Add full manual transactions
dc2d9eb
@astrojarred
Allow return of signed tx without submission
d63666f
@astrojarred
Automatically create stake credentials
942cdff
@astrojarred
Format with Black
1928fd5
@astrojarred
Support signing messages with stake keys
aeb0b1f
@astrojarred
Update todo list
a37319c
@astrojarred
Add script interaction
30ea14b
@astrojarred
Update when stake keys are generated
08a5997
@astrojarred
Add Policy script property
ea24571
@astrojarred
Copy link
Contributor Author

astrojarred commented Nov 15, 2022

Quick update-- I've finally managed to integrate mypy so that the checks do not fail anymore. In addition I've gotten coverage up to ~44%. Still some tests to write but I'm closing in on this.
🔜

@cffls cffls added the enhancement New feature or request label Dec 7, 2022
@KINGH242
Copy link
Contributor

KINGH242 commented Jun 11, 2024

How can I help with this? I can't see the logs for the failed checks as it was too long ago. I am working on a project that would benefit from having the wallet stuff abstracted away into PyCardano.

@cffls
Copy link
Collaborator

cffls commented Jun 16, 2024

@KINGH242 that's great! This PR is staled and I completely forget about it.. I think a few type checks are failing. If those are fixed we should be able to merge it.

@astrojarred
Copy link
Contributor Author

astrojarred commented Jun 16, 2024

Hey all, I dropped the ball a bit on this one!

I think I got stuck with test writing-- I recall that I mainly had trouble with the mocking of the blockfrost API and tx submission as it's something I had no experience with.

Also happy to help out wherever possible and finally get this done.

@KINGH242
Copy link
Contributor

KINGH242 commented Jun 27, 2024

Hey @astrojarred, I added some test and fixed a few things to allow it to work with the latest changes. I submitted a PR here astrojarred#33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cffls cffls cffls left review comments

@daehan-koreapool daehan-koreapool daehan-koreapool left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@astrojarred @codecov-commenter @cffls @daehan-koreapool @robinboening @KINGH242